Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure HTTP requests are handled asynchronously in all cases. #1

Closed
zenhack opened this issue Oct 23, 2016 · 1 comment
Closed

Make sure HTTP requests are handled asynchronously in all cases. #1

zenhack opened this issue Oct 23, 2016 · 1 comment
Labels
invalid

Comments

@zenhack
Copy link
Owner

zenhack commented Oct 23, 2016

I suspect we're missing some cases, where a blocked request can prevent further requests from being handled.
@zenhack zenhack added the bug label Oct 23, 2016
@zenhack zenhack mentioned this issue Oct 23, 2016
Open
@zenhack zenhack added invalid and removed bug labels Oct 28, 2016
@zenhack
Copy link
Owner Author

zenhack commented Oct 28, 2016

We seem to be doing this correctly. I just pushed a basic test for this, but also, we are calling ServerToClient in our implementation of NewSession, so we should be fine. I'm going to close this as invalid

@zenhack zenhack closed this as completed Oct 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
invalid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zenhack