Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug image with-puppeter #18

Closed
OscarSotoSanchez opened this issue Nov 12, 2018 · 4 comments
Closed

Bug image with-puppeter #18

OscarSotoSanchez opened this issue Nov 12, 2018 · 4 comments

Comments

@OscarSotoSanchez
Copy link

OscarSotoSanchez commented Nov 12, 2018

Hi, you have a bug in the docker image with-puppeter, if you don't add a path "/usr/src/app" in the command "npm install", you will recived a error message in the execution.

module.js:549
throw err;
^

Error: Cannot find module 'puppeteer'
at Function.Module._resolveFilename (module.js:547:15)
at Function.Module._load (module.js:474:25)
at Module.require (module.js:596:17)
at require (internal/module.js:11:18)
at Object. (/usr/src/app/pdf.js:1:81)
at Module._compile (module.js:652:30)
at Object.Module._extensions..js (module.js:663:10)
at Module.load (module.js:565:32)
at tryModuleLoad (module.js:505:12)
at Function.Module._load (module.js:497:3)

Then, if you modify the command for "RUN npm install /usr/src/app" you will resolved the problem. Best regards.

@jlandure
Copy link
Owner

Hi @OscarSotoSanchez 👋
Thanks for your report!

I will have a look but normally the workdir is already set in the Dockerfile.
WORKDIR /usr/src/app

Can you describe your docker container launch command? Thanks! 👍

@jlandure
Copy link
Owner

For you information @OscarSotoSanchez, I've set the WORKDIR instruction at the beginning of the Dockerfile.

@jlandure
Copy link
Owner

jlandure commented May 3, 2020

@all-contributors please add @OscarSotoSanchez for bug

@allcontributors
Copy link
Contributor

@jlandure

I've put up a pull request to add @OscarSotoSanchez! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants