Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if Juypter is installed #2567

Closed
robnoflop opened this issue Mar 27, 2024 · 2 comments · Fixed by #2571
Closed

Check if Juypter is installed #2567

robnoflop opened this issue Mar 27, 2024 · 2 comments · Fixed by #2571
Assignees
Labels
bug Something isn't working

Comments

@robnoflop
Copy link

robnoflop commented Mar 27, 2024

Hey,

I tried using ZenML for the first time. With new tools, I always start with a clean virtual environment. After installing ZenML and running zenml go, I encountered the following error:

image

image

The error occurs at this line:

subprocess.check_call(["jupyter", "notebook"], cwd=zenml_tutorial_path)

After installing jupyter in my venv everthing works fine.

Maybe you could simply add this simple check, as described in this Stack Overflow post: --> https://stackoverflow.com/questions/1051254/check-if-python-package-is-installed

Best,
Robert

@strickvl
Copy link
Contributor

Thanks for opening the issue! You're right we could have a nicer handling of this, esp since you're just following the instructions on our README etc. I'll open a PR to make this clearer.

@strickvl strickvl linked a pull request Mar 28, 2024 that will close this issue
@strickvl strickvl added the bug Something isn't working label Mar 28, 2024
@strickvl strickvl self-assigned this Mar 28, 2024
@strickvl
Copy link
Contributor

strickvl commented Apr 9, 2024

Merged the fix for this in. Thanks again @robnoflop for the report!

@strickvl strickvl closed this as completed Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants