Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate correct ARG_INFO of getter #2386

Closed
Jeckerson opened this issue Sep 5, 2022 · 1 comment
Closed

Generate correct ARG_INFO of getter #2386

Jeckerson opened this issue Sep 5, 2022 · 1 comment
Assignees

Comments

@Jeckerson
Copy link
Member

Current code:

protected transaction = null { get };

will generate incorrect ARG_INFO which will cause seg fault:

ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_phalcon_mvc_model_gettransaction, 0, 0, IS_NULL, 1)
ZEND_END_ARG_INFO()

It is impossible to have IS_NULL inside 4th argument of ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX it always must contain valid namespace class.

@Jeckerson
Copy link
Member Author

Fixed in #2387

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant