Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Coverity CID: 220314] Untrusted value as argument in subsys/bluetooth/services/ots/ots_dir_list.c #33830

Closed
zephyrbot opened this issue Mar 29, 2021 · 0 comments · Fixed by #33872
Assignees
Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug

Comments

@zephyrbot
Copy link
Collaborator

Static code scan issues found in file:

https://github.com/zephyrproject-rtos/zephyr/tree/169144afa1826511ee6ec3f53d590b2c0d39d3d4/subsys/bluetooth/services/ots/ots_dir_list.c#L124

Category: Insecure data handling
Function: bt_ots_dir_list_obj_remove
Component: Bluetooth
CID: 220314

Details:

memmove(dir_list->net_buf.data + offset,

118             __ASSERT(len, "Invalid object length");
119    
120             if (id == obj->id) {
121                 /* Delete object by moving memory after the object to
122                  * the objects current location
123                  */
>>>     CID 220314:  Insecure data handling  (TAINTED_SCALAR)
>>>     Passing tainted expression "dir_list->net_buf.len - (offset + len)" to "memmove", which uses it as an offset. [Note: The source code implementation of the function has been overridden by a builtin model.]
124                 memmove(dir_list->net_buf.data + offset,
125                     dir_list->net_buf.data + offset + len,
126                     dir_list->net_buf.len - (offset + len));
127                 /* Decrement net_buf len to new length */
128                 dir_list->net_buf.len -= len;
129                 break;

Please fix or provide comments in coverity using the link:

https://scan9.coverity.com/reports.htm#v29271/p12996

Note: This issue was created automatically. Priority was set based on classification
of the file affected and the impact field in coverity. Assignees were set using the CODEOWNERS file.

@zephyrbot zephyrbot added bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug labels Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants