west: runners: jlink: JLink.exe name collision

[JordanYates]

Describe the bug

The jlink binary runner uses the location of JLink.exe or JLinkExe to determine the location of the JLink libraries,

zephyr/scripts/west_commands/runners/jlink.py

Line 26 in 117039c

DEFAULT_JLINK_EXE = 'JLink.exe' if sys.platform == 'win32' else 'JLinkExe'

zephyr/scripts/west_commands/runners/jlink.py

Line 38 in 117039c

commander=DEFAULT_JLINK_EXE,

zephyr/scripts/west_commands/runners/jlink.py

Lines 177 to 178 in 117039c

	lib = Library(dllpath=os.fspath(Path(self.commander).parent /
	libname))

Unfortunately the OpenJDK runtime also distributes an executable called jlink.exe : https://strontic.github.io/xcyclopedia/library/jlink.exe-15C86A7D8376EC476DD2AE27EAEE31D1.html

Trying to run west flash with the runtime on the path results in errors like:

packages\pylink\library.py", line 286, in __init__
    self.load(dllpath)
  File "C:\Python310\lib\site-packages\pylink\library.py", line 392, in load
    with open(self._path, 'rb') as inputfile:
FileNotFoundError: [Errno 2] No such file or directory: 'C:\\Program Files\\Eclipse Adoptium\\jdk-11.0.16.101-hotspot\\bin\\JLink_x64.dll'

Expected behavior

The jlink plugin should ideally be more resilient to finding a SEGGER executable, not any old executable called jlink.exe.

Impact

Annoyance, the correct path can be selected with west flash --commander /path/to/JLink.exe

Environment (please complete the following information):

• OS: Windows

[github-actions]

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

[github-actions]

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

[github-actions]

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

[github-actions]

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

[github-actions]

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

[github-actions]

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

[ehughes]

@JordanYates FYI. Thanks for this. I ran into this as well.

[Xentax5]

@JordanYates Also thanks. Same issue here.

[dleach02]

We need a different assignee. Does someone on this ticket want to take this on?

[henry-202308]

I have also encountered this problem, and a temporary solution is:
Add the required Jlink.exe path to the first line of the environment variable PATH.

[github-actions]

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.