Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check incoming IPv6 multicast scope packets #10995

Merged
merged 8 commits into from Nov 2, 2018

Conversation

jukkar
Copy link
Member

@jukkar jukkar commented Nov 1, 2018

No description provided.

If we receive an IPv6 packet with interface scope multicast
address FF01:: then we must drop it as those addresses are
reserved for local network traffic only.

Fixes zephyrproject-rtos#10959

Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
Test that we drop the received packet if the destination
address is interface scope multicast address.

Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
The zero scope is a reserved value so it should not be used
so drop it.

Fixes zephyrproject-rtos#10958

Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
Test that we drop the received packet if the destination
address is zero scope (ff00::) multicast address.

Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
If we receive an IPv6 packet with site scope multicast
address FF05:: then we must drop it as those addresses are
reserved for site network traffic only.

Fixes zephyrproject-rtos#10960

Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
Test that we drop the received packet if the destination
address is site scope (ff05::) multicast address.

Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
If we receive an IPv6 packet with organisation scope multicast
address FF08:: then we must drop it as those addresses are
reserved for organisation network traffic only.

Fixes zephyrproject-rtos#10961

Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
Test that we drop the received packet if the destination
address is organisation scope (ff08::) multicast address.

Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@ae6ed44). Click here to learn what that means.
The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #10995   +/-   ##
=========================================
  Coverage          ?   53.25%           
=========================================
  Files             ?      217           
  Lines             ?    26692           
  Branches          ?     5923           
=========================================
  Hits              ?    14215           
  Misses            ?    10059           
  Partials          ?     2418
Impacted Files Coverage Δ
include/net/net_ip.h 71.26% <80%> (ø)
subsys/net/ip/ipv6.c 58.69% <90.9%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae6ed44...9428713. Read the comment docs.

Copy link
Collaborator

@tbursztyka tbursztyka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine to me.

Remember to send a patch in another PR normalizing names (s/net_is_/net__is ).

@jukkar
Copy link
Member Author

jukkar commented Nov 2, 2018

Remember to send a patch in another PR normalizing names (s/net_is_/net__is ).

Yes, I will do that.

@jukkar jukkar merged commit 0a3b5f2 into zephyrproject-rtos:master Nov 2, 2018
@jukkar jukkar deleted the bug-10959-lo-mcast-dst branch November 2, 2018 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants