-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers: can: st: rename devicetree compatibles, Kconfig symbols, and implementation files #61494
Merged
carlescufi
merged 8 commits into
zephyrproject-rtos:main
from
vestas-wind-systems:can_stm32_driver_renames
Aug 16, 2023
Merged
drivers: can: st: rename devicetree compatibles, Kconfig symbols, and implementation files #61494
carlescufi
merged 8 commits into
zephyrproject-rtos:main
from
vestas-wind-systems:can_stm32_driver_renames
Aug 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinjaeger
previously approved these changes
Aug 15, 2023
str4t0m
previously approved these changes
Aug 15, 2023
@henrikbrixandersen please rebase |
Fold the contents of the private header for the STM32 bxCAN driver into the implementation file. Signed-off-by: Henrik Brix Andersen <hebad@vestas.com>
Rename the STM32 bxCAN driver DTS compatible, Kconfig symbol, and implementation file to match the naming used in the ST reference manuals. Signed-off-by: Henrik Brix Andersen <hebad@vestas.com>
Fold the Kconfig options for the STM32 FDCAN driver into the main Kconfig.stm32 file. Signed-off-by: Henrik Brix Andersen <hebad@vestas.com>
Rename the STM32 FDCAN driver Kconfig symbol and implementation file to match the naming used in the ST reference manuals. Signed-off-by: Henrik Brix Andersen <hebad@vestas.com>
Rename the STM32 FDCAN node labels to match to naming used in the ST reference manuals. This also matches the naming used in the STM32 FDCAN pinctrl macros. Signed-off-by: Henrik Brix Andersen <hebad@vestas.com>
Fold the Kconfig options for the STM32H7 FDCAN driver into the main Kconfig.stm32 file. Signed-off-by: Henrik Brix Andersen <hebad@vestas.com>
Rename the STM32H7 FDCAN driver Kconfig symbol and implementation file to match the naming used in the ST reference manuals. Signed-off-by: Henrik Brix Andersen <hebad@vestas.com>
Rename the STM32H7 FDCAN node labels to match to naming used in the ST reference manuals. This also matches the naming used in the STM32H7 FDCAN clock and pinctrl macros. Signed-off-by: Henrik Brix Andersen <hebad@vestas.com>
55074fb
to
7ae0b2b
Compare
Rebased to pull in changes from cec279b. |
str4t0m
approved these changes
Aug 16, 2023
martinjaeger
approved these changes
Aug 16, 2023
rexut
added a commit
to tiacsys/bridle
that referenced
this pull request
Sep 22, 2023
This renames the compatible string to 'stm32-bxcan' and add default properties 'sjw' and 'sample-point' related to upstream changes: - zephyrproject-rtos/zephyr#61494 - zephyrproject-rtos/zephyr#62816 Signed-off-by: Stephan Linz <linz@li-pro.net>
rexut
added a commit
to tiacsys/bridle
that referenced
this pull request
Sep 22, 2023
This removes deprecated properties and introduce the default timing setup by 'sample-point' with 88.9% for 1000 kbit/sec related to upstream changes: - zephyrproject-rtos/zephyr#61494 - zephyrproject-rtos/zephyr#62816 Signed-off-by: Stephan Linz <linz@li-pro.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: CAN
area: Devicetree Binding
PR modifies or adds a Device Tree binding
platform: STM32
ST Micro STM32
Release Notes Required
Release notes required for this change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series of patches renames the various STM32 CAN controller driver devicetree compatibles, Kconfig symbols, and implementation files to match the naming used in the ST reference manuals.
Back when Zephyr only supported one STM32 CAN controller variant (bxCAN), the existing naming made more sense. Now Zephyr supports three different STM32 CAN controllers and the current naming is confusing.
To aid in backporting any future bug fixes, I have not renamed the C symbols and macros internal to the drivers.