arch: arm: cortex_m: Move default configs to a file and add consistency checks #64978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ithinuel
requested review from
nashif,
Mani-Sadhasivam,
vanti,
arnopo,
erwango,
yonsch,
fkokosinski,
kgugala,
MulinChao,
ChiHuaL,
manuargue,
mmahadevan108,
dleach02,
nandojve,
ifyall,
npal-cy,
MaureenHelm,
galak and
ioannisg
as code owners
ithinuel
force-pushed
the
modules/cmsis/check_config_consistency
branch
2 times, most recently
from
bd754a7
to
e4cf90a
Compare
ithinuel
added
Enhancement
ithinuel
force-pushed
the
modules/cmsis/check_config_consistency
branch
from
e4cf90a
to
fbeb38a
Compare
|
I get the same error on |
ithinuel
force-pushed
the
modules/cmsis/check_config_consistency
branch
from
fbeb38a
to
42fc662
Compare
microbuilder
requested changes
Nov 27, 2023
This adds kconfig entries for Performance Monitoring Unit (PMU). Signed-off-by: Wilfried Chauveau <wilfried.chauveau@arm.com>
Kconfig parameters, header’s default & silicon vendor’s SDK configuration for CMSIS Core, must be consistent. Depending on the inclusion order of the headers, this is currently not always the case. This change introduces consistency checks & enusers defaults match their Kconfig settings. Signed-off-by: Wilfried Chauveau <wilfried.chauveau@arm.com>
This change adds checks to validate consistency between Zephyr’s Kconfig settings and cmsis configuration defined in SiP’s sdk provided headers. This change also introduces a config to enable cmsis’ own checks which emits warnings if a parameter relies on auto-populated default values. Signed-off-by: Wilfried Chauveau <wilfried.chauveau@arm.com>
This changes remove extraneous includes causing issues with cycles in includes subsequently having code requiring definitions from CMSIS while it’s configuration hasn’t completed yet. Signed-off-by: Wilfried Chauveau <wilfried.chauveau@arm.com>
ithinuel
force-pushed
the
modules/cmsis/check_config_consistency
branch
from
42fc662
to
3b9e7ba
Compare
Caches are optional on cortex-m7, having CPU_HAS_*CACHE in CPU_CORTEX_M7 definition renders them mandatory. Signed-off-by: Wilfried Chauveau <wilfried.chauveau@arm.com>
Some SoC have missing feature selections in their Kconfig. Some others are missing includes of CMSIS-Core headers. Signed-off-by: Wilfried Chauveau <wilfried.chauveau@arm.com>
ithinuel
force-pushed
the
modules/cmsis/check_config_consistency
branch
from
3b9e7ba
to
250ba9b
Compare
microbuilder
approved these changes
Nov 27, 2023
microbuilder
requested review from
povergoing and
SgrrZhf
and removed request for
dleach02,
yonsch,
ifyall,
npal-cy,
MulinChao and
ChiHuaL
povergoing
approved these changes
Dec 5, 2023
manuargue
added a commit
to nxp-zephyr/zephyr
that referenced
this pull request
Dec 5, 2023
Include CMSIS headers, missing to be added in zephyrproject-rtos#64978. And align CPU_HAS_xCACHE symbols with the CMSIS feature definitions in the device headers so that both have the same value. Signed-off-by: Manuel Argüelles <manuel.arguelles@nxp.com>
manuargue
added a commit
to nxp-zephyr/zephyr
that referenced
this pull request
Dec 5, 2023
Following changes in zephyrproject-rtos#64978, align CPU_HAS_xCACHE symbols with the CMSIS feature definitions in the device headers so that both have the same value. Signed-off-by: Manuel Argüelles <manuel.arguelles@nxp.com>
manuargue
added a commit
to nxp-zephyr/zephyr
that referenced
this pull request
Dec 5, 2023
Following changes in zephyrproject-rtos#64978, align CPU_HAS_xCACHE symbols with the CMSIS feature definitions in the device headers so that both have the same value. Fixes zephyrproject-rtos#66147 Signed-off-by: Manuel Argüelles <manuel.arguelles@nxp.com>
manuargue
added a commit
to nxp-zephyr/zephyr
that referenced
this pull request
Dec 5, 2023
Following changes in zephyrproject-rtos#64978, align CPU_HAS_xCACHE symbols with the CMSIS feature definitions in the device headers so that both have the same value. Fixes zephyrproject-rtos#66147 Signed-off-by: Manuel Argüelles <manuel.arguelles@nxp.com>
panxxhub
pushed a commit
to panxxhub/zephyr
that referenced
this pull request
Dec 7, 2023
Following changes in zephyrproject-rtos#64978, align CPU_HAS_xCACHE symbols with the CMSIS feature definitions in the device headers so that both have the same value. Fixes zephyrproject-rtos#66147 Signed-off-by: Manuel Argüelles <manuel.arguelles@nxp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR separates the default configuration setting from main
cmsis_core.hpath and add checks ensuring that Kconfig defines do match CMSIS' configuration.