Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#218 delete lost issues when we can't find them #225

Merged
merged 5 commits into from
Aug 4, 2024

Conversation

Suban05
Copy link
Contributor

@Suban05 Suban05 commented Aug 4, 2024

Changes

  • Added removing the issue when the GitHub API returns a 404 status
  • Added tests

Fixes #218

@Suban05
Copy link
Contributor Author

Suban05 commented Aug 4, 2024

@yegor256 can you please check if I am using the correct factbase for deleting a lost issue?

@yegor256
Copy link
Member

yegor256 commented Aug 4, 2024

@Suban05 all good, but small comment above

@Suban05
Copy link
Contributor Author

Suban05 commented Aug 4, 2024

@yegor256 fixed

@Suban05
Copy link
Contributor Author

Suban05 commented Aug 4, 2024

@Yegorov can you review it, please?

@Yegorov
Copy link
Contributor

Yegorov commented Aug 4, 2024

@Suban05 Looks great, no complaints!

@yegor256
Copy link
Member

yegor256 commented Aug 4, 2024

@Yegorov you have to make a "review" (click "submit review"), otherwise it won't count

@yegor256
Copy link
Member

yegor256 commented Aug 4, 2024

@Yegorov like this:

Screenshot 2024-08-04 at 12 42 13

Copy link
Contributor

@Yegorov Yegorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, no complaints!

@yegor256
Copy link
Member

yegor256 commented Aug 4, 2024

@rultor merge

@rultor
Copy link
Contributor

rultor commented Aug 4, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 78cf853 into zerocracy:master Aug 4, 2024
8 checks passed
@rultor
Copy link
Contributor

rultor commented Aug 4, 2024

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 9min)

@yegor256
Copy link
Member

yegor256 commented Aug 4, 2024

@Suban05 thanks!

@0crat
Copy link

0crat commented Aug 4, 2024

@yegor256 Hey there, code wizard! 🧙‍♂️ Awesome job on that review! You've snagged +24 points for your effort: +25 for stepping up, +9 for tackling those 93 hits-of-code (nice!), but we had to dock -10 because there were only 3 comments. Remember, more feedback is always better! Your current score sits at -535. Keep up the great work and let's aim for even more engaging reviews next time!

@0crat
Copy link

0crat commented Aug 5, 2024

@Suban05 Awesome work! 🎉 You just scored +46 points (+30 base + 16 for 167 hits-of-code). Your total's now +152. Keep the momentum going - we love seeing your contributions!

@Suban05 Suban05 deleted the 218 branch August 10, 2024 05:09
@0crat
Copy link

0crat commented Aug 10, 2024

@Suban05 Thanks for your review! Here's the breakdown of your +5 points: +25 base points, -40 for self-review (not recommended), +0.02 points per hit-of-code (capped at 30), +1 point per comment (max 20), adjusted to the minimum 5 points. Remember, reviewing others' code often yields higher rewards. Your current balance is +302. Keep up the good work! 💻

@0crat
Copy link

0crat commented Aug 10, 2024

@Yegorov Hey there! 👋 Awesome job on the review! You've snagged +36 points for this one: +25 for being an author, and +11 for those 11 insightful comments you made. 💬 That's pretty good, considering we cap comment points at 20. Your running balance is now at a solid +194. Keep up the great work, and remember, more hits-of-code and comments could bump up your points even more next time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

delete lost issues when we can't find them
5 participants