Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete lost issues when we can't find them #218

Closed
yegor256 opened this issue Aug 2, 2024 · 5 comments · Fixed by #225
Closed

delete lost issues when we can't find them #218

yegor256 opened this issue Aug 2, 2024 · 5 comments · Fixed by #225
Assignees
@Suban05
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@yegor256
Copy link
Member

yegor256 commented Aug 2, 2024

This is what I'm getting from label-was-attached.rb:

GET https://api.github.com/repositories/728758275/issues/161/timeline?per_page=100: 404 - Not Found // See: https://docs.github.com/rest/issues/timeline#list-timeline-events-for-an-issue

This means that the issue is gone (transferred to another repository). I believe, we should catch this type of error and remove the issue-was-opened fact from the factbase.
@yegor256 yegor256 added bug Something isn't working help wanted Extra attention is needed labels Aug 2, 2024
@yegor256 yegor256 changed the title remove-lost-issues.rb delete lost issues when we can't find them Aug 2, 2024
@Suban05
Copy link
Contributor

Suban05 commented Aug 3, 2024

@yegor256 may I take this one?

@yegor256
Copy link
Member Author

yegor256 commented Aug 3, 2024

@Suban05 please, go ahead

Suban05 added a commit to Suban05/judges-action that referenced this issue Aug 4, 2024
@Suban05
zerocracy#218 tests
653d6fb
Suban05 added a commit to Suban05/judges-action that referenced this issue Aug 4, 2024
@Suban05
zerocracy#218 remove lost issue
f9b9413
Suban05 added a commit to Suban05/judges-action that referenced this issue Aug 4, 2024
@Suban05
zerocracy#218 empty lines
e2e6c30
@Suban05 Suban05 mentioned this issue Aug 4, 2024
Merged
Suban05 added a commit to Suban05/judges-action that referenced this issue Aug 4, 2024
@Suban05
zerocracy#218 more tests
b7d5373
Suban05 added a commit to Suban05/judges-action that referenced this issue Aug 4, 2024
@Suban05
zerocracy#218 don't delete facts related to other repositories
c67cf2e
@yegor256
Copy link
Member Author

yegor256 commented Aug 4, 2024

@rultor release, tag is 0.0.40

@rultor
Copy link
Contributor

rultor commented Aug 4, 2024

@rultor release, tag is 0.0.40

@yegor256 OK, I will release it now. Please check the progress here

@rultor
Copy link
Contributor

rultor commented Aug 4, 2024

@rultor release, tag is 0.0.40

@yegor256 Done! FYI, the full log is here (took me 9min)

@yegor256 yegor256 mentioned this issue Aug 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Suban05 Suban05

Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#218 delete lost issues when we can't find them Suban05/judges-action
3 participants
@yegor256 @rultor @Suban05