Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

Latest build of kami crashes with future #60

Closed
5HT2 opened this issue Oct 14, 2018 · 4 comments
Closed

Latest build of kami crashes with future #60

5HT2 opened this issue Oct 14, 2018 · 4 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@5HT2
Copy link
Contributor

5HT2 commented Oct 14, 2018

Steps to reproduce the problem

  1. Have Future and Kami in \.minecraft\mods\1.12.2
  2. Launch
  3. See a crash
  4. Try again without Future
  5. Game launches normally

Might be related to re-write, which is the main big change when switching versions
Or it might be related to #31

Specifications

  • Version: Latest build as of October 14th
  • Platform: Windows 10 x64

Logs

EDIT: Logs removed due to privacy concerns

@ghost ghost added bug Something isn't working help wanted Extra attention is needed labels Oct 15, 2018
@5HT2
Copy link
Contributor Author

5HT2 commented Oct 15, 2018

Update: I sent wrong logs, as for some reason the client did not generate logs with crash with Kami + Future. When I get home I will look into why it won't generate logs.

@5HT2
Copy link
Contributor Author

5HT2 commented Oct 15, 2018

New update:

@zeroeightysix send a quick and dirty patch which disables the injecting mechanism of safewalk which future doesn't like, so this is a temporary fix, that works. In effect safewalk doesn't work.

The jar:

KAMI-b9-release-custom-fix.jar.gz
(zipped, need to extract first)

@ZeroMemes
Copy link
Contributor

ZeroMemes commented Oct 22, 2018

Lol this literally shouldn't have been closed. The custom fix that @ChristoferMinestar provided literally said:

[...] so this is a temporary fix, that works.

This issue should either be resolved or marked as won't resolve. There was no need to create a new issue for it (#61)

@5HT2
Copy link
Contributor Author

5HT2 commented Oct 22, 2018

@ZeroMemes, I closed this because the goal is now not to solve why Kami is crashing with Future, but what can we do to fix this.

@zeroeightysix zeroeightysix mentioned this issue Oct 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants