print warning message when copilot finds no mode-specific offset #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* See copilot-emacs#179. * Modify copilot--infer-indentation-offset to accept numeric values from copilot--indentation-alist. * Add (emacs-lisp-mode 1) to copilot--indentation-alist.
This reverts commit 38bd7a8.
|
Similar to #198, I think we should not invent our own "warning suppression" method. |
|
I agree with your suggestion, and wasn't aware of the standard way to
communicate warnings. Thanks! (As far as I'm concerned, please feel free
to PR this if you know how to do it the right way)
…On Mon, Oct 30, 2023 at 6:49 AM Yikai Zhao ***@***.***> wrote:
Similar to #198 <#198>, I think
we should not invent our own "warning suppression" method.
—
Reply to this email directly, view it on GitHub
<#191 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APC5ZXJHNJT7VR3NZIVKMK3YB45VTAVCNFSM6AAAAAA5ZZRTHSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBUGUZDINZYG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Though I'm not sure if it's ok to simply remove the |
|
Given that I both reported the issue and submitted the fix, I would guess that not too many people are using this setting, so you shouldn't worry too much about having to properly deprecate it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #179. This is my best attempt to implement the suggestion made in the comment #179 (comment).