Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for VS2010 #6

Closed
HughPowell opened this issue Apr 14, 2014 · 5 comments
Closed

Changes for VS2010 #6

HughPowell opened this issue Apr 14, 2014 · 5 comments

Comments

@HughPowell
Copy link
Contributor

Hi,

I've made changes to be able to work with VS2010 (added project files and fixed compilation issues). As the VS2010 compiler doesn't implement all of the C++11 language features there's quite a few changes. The only way I can think to make it build for all platforms with be with liberal use of preprocessor definitions, making it quite a mess. Would this be better be kept as 2 separate projects?

Cheers,
Hugh

@evoskuil
Copy link
Contributor

@HughPowell Thanks for doing the work to expand usability below C++11. This was written for czmq integration with libbitcoin's Obelisk by @genjix, and that code utilizes latest compiler features, but for more general use with zmq it's better to keep it at a lower compiler version. We were planning to add exports, so it's great that you've done this too.

There are a couple of issues in the project/props files. I would ask that you create a pull request for the cpp changes and I'll expand the VC project coverage to vs2012 and vs2010 once we have verified the build.

@HughPowell
Copy link
Contributor Author

C++ changes in #8

@evoskuil
Copy link
Contributor

@HughPowell Do the exports compile properly for you in a DLL build?

@HughPowell
Copy link
Contributor Author

@evoskuil Sorry, forgot to include the changes to the preprocessor definitions which were to include LIBCZMQ_EXPORTS for the DLL builds. Looks like you've taken care of all that with #9
Cheers

@evoskuil
Copy link
Contributor

Yes, it all looks good presently. Thanks for making the changes to expand this to v100 and v110 as well as dynamic linking! Note that libsodium has adopted the three platform builds that follow the same pattern, so everything should work well once the libzmq pull request is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants