-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes for VS2010 #6
Comments
@HughPowell Thanks for doing the work to expand usability below C++11. This was written for czmq integration with libbitcoin's Obelisk by @genjix, and that code utilizes latest compiler features, but for more general use with zmq it's better to keep it at a lower compiler version. We were planning to add exports, so it's great that you've done this too. There are a couple of issues in the project/props files. I would ask that you create a pull request for the cpp changes and I'll expand the VC project coverage to vs2012 and vs2010 once we have verified the build. |
C++ changes in #8 |
@HughPowell Do the exports compile properly for you in a DLL build? |
Yes, it all looks good presently. Thanks for making the changes to expand this to |
Hi,
I've made changes to be able to work with VS2010 (added project files and fixed compilation issues). As the VS2010 compiler doesn't implement all of the C++11 language features there's quite a few changes. The only way I can think to make it build for all platforms with be with liberal use of preprocessor definitions, making it quite a mess. Would this be better be kept as 2 separate projects?
Cheers,
Hugh
The text was updated successfully, but these errors were encountered: