The StreamEngine didn't handle well instantiation failure #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The allocation of decoder or encoder could faild if given a wrong class, but in this it will return null and print a stack. It now return ZError.InstantiationException. But it can also throw a more classical IllegalArgumentException. It also use generic instead of type cast.
fbacchella
force-pushed
the
exception_streamengine
branch
from
6b07b9f
to
ec15b2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The allocation of decoder or encoder could faild if given a wrong class, but
in this it will return null and print a stack. It now return ZError.InstantiationException.
But it can also throw a more classical IllegalArgumentException. It also
use generic instead of type cast.