Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

numpy.typing and sisl requirements #543

Closed
tfrederiksen opened this issue Feb 27, 2023 · 2 comments
Closed

numpy.typing and sisl requirements #543

tfrederiksen opened this issue Feb 27, 2023 · 2 comments

Comments

@tfrederiksen
Copy link
Contributor

According to requirements.txt, sisl needs numpy>=1.13. However, the development version now relies on numpy.typing that is new in numpy 1.20. Update?
@zerothi
Copy link
Owner

zerothi commented Feb 27, 2023

You are absolutely correct, I'll have a look at it! Thanks for noticing!

@zerothi
Copy link
Owner

zerothi commented Feb 28, 2023

I believe this should be fixed in the latest commit.

Thanks for noticing, this is still all new to me, but should be valuable for the documentation etc.

@zerothi zerothi closed this as completed Feb 28, 2023
tfrederiksen referenced this issue Feb 28, 2023
@zerothi
doc: fixed imports that broke numpy requirement
a841e47 
Now the typing should be a bit more stable.

Signed-off-by: Nick Papior <nickpapior@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zerothi @tfrederiksen