Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

body with direction : rtl #21

Closed
mahmoudZakaria90 opened this issue Nov 30, 2015 · 4 comments
Closed

body with direction : rtl #21

mahmoudZakaria90 opened this issue Nov 30, 2015 · 4 comments

Comments

@mahmoudZakaria90
Copy link

sorry for the two issues, i just want to ask about giving the body direction : rtl
because when i did this before any jquery plugin i embed in my document like : gallery slider or simple bootstrap slider were destroyed
how can i fix this ?

i tried before this line i've created :
:not(body),:not(div),*:not(html){ direction: rtl }
it works

@zeroxme
Copy link
Owner

zeroxme commented Nov 30, 2015

your question is kind of irrelevant to the purpose of the repo but I don't advice using this line of code to be honest because it's too general. Also using the * has some performance issues.

The idea of converting any code to RTL is to change properties that affects the direction like floating, margins, paddings, clearing and etc... JS has nothing to do with directions unless if the JS code is direction dependent which means the CSS properties that affects directions are being manipulated inside the JS

@mahmoudZakaria90
Copy link
Author

the line of code is too general ? ok what's wrong ?!
i know the purpose of the repo and what you said about the purpose is so right but the body when it has that direction property also will cause a performance issues like js plugins and you are right about JS code direction dependent but don't you think this is must be considered as an issue also ?? and each time i embed a plugin of those with direction dependence must give it a direction :ltr

@mahmoudZakaria90
Copy link
Author

for example :
-flex-slider
-owl-carousel
-bx-slider
-pgwCarousel

@zeroxme
Copy link
Owner

zeroxme commented Nov 30, 2015

I totally get your point. If this property would affect any plugin within bootstrap I would fix it but it's not, so it's irrelevant. You can add/fix what you want to suite your needs in your own custom code

@zeroxme zeroxme closed this as completed Nov 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants