Updated the documentation on uploading. #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2,43 +2,40 @@ Uploading to pypi (or custom servers) | |||
| ======================================= | |||
|
|
|||
| When the (full)release command tries to upload your package to a pypi server, | |||
| zest.releaser basically just executes the command ``python setup.py register | |||
| sdist --formats=zip upload``. | |||
| zest.releaser basically just executes the command ``twine upload``. | |||
There was a problem hiding this comment.
What about python setup.py sdist? Does twine upload do that nowadays?
There was a problem hiding this comment.
To be more constructive: perhaps rephrase as
basically just executes the commands
python setup.py sdistandtwine upload.
There was a problem hiding this comment.
Ah, true, setup.py sdist is still needed yes. I have updated the text along those lines.
We are not using `setup.py register/upload` anymore, but use twine for both. Removed the old-style `.pypirc` from the docs.
mauritsvanrees
force-pushed
the
maurits-improve-uploading-docs
branch
from
6da30cc
to
7626ab2
Compare
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are not using
setup.py register/uploadanymore, but use twine for both.Removed the old-style
.pypircfrom the docs.This builds on and replaces pull request #185