Do not fail when tag versions cannot be parsed.

CHANGES.rst

@@ -4,7 +4,10 @@ Changelog for zest.releaser
 8.0.0a2 (unreleased)
 --------------------
 
-- Nothing changed yet.
+- Do not fail when tag versions cannot be parsed.
+  This can happen in ``lasttaglog``, ``lasttagdiff``, and ``bumpversion``, with ``setuptools`` 66 or higher.
+  Fixes `issue 408 <https://github.com/zestsoftware/zest.releaser/issues/408>`_.
+  [maurits]
 
 
 8.0.0a1 (2023-02-08)

zest/releaser/tests/functional-git.txt

@@ -150,5 +150,5 @@ The changelog and setup.py are at 0.2 and indicate dev mode:
 And there are no uncommitted changes:
 
     >>> print(execute_command(["git", "status"]))
-    On branch master
+    On branch main
     nothing to commit, working directory clean

zest/releaser/tests/functional.py

@@ -71,7 +71,7 @@ def _mock_urlopen(url):
     gitsourcedir = os.path.join(test.tempdir, "tha.example-git")
     shutil.copytree(sourcedir, gitsourcedir)
     os.chdir(gitsourcedir)
-    execute_command(["git", "init"])
+    execute_command(["git", "init", "-b", "main"])
     # Configure local git.
     execute_command(["git", "config", "--local", "user.name", "Temp user"])
     execute_command(["git", "config", "--local", "user.email", "temp@example.com"])

zest/releaser/tests/git.txt

@@ -57,7 +57,7 @@ Commit it:
     ['git', 'commit', '-a', '-m', 'small tweak', '-n']
 
 In some cases we get this output:
-``[master ...] small tweak``
+``[main ...] small tweak``
 and in other this:
 ``Created commit ...: small tweak``
 
@@ -189,14 +189,14 @@ The tempdir should be at tag 0.1.  The last line ought to be "a = 2"
     ...
     a = 2
 
-Change back to the source directory and return to the master branch.
+Change back to the source directory and return to the main branch.
 
     >>> os.chdir(gitsourcedir)
-    >>> cmd = [['git', 'checkout', 'master'],
+    >>> cmd = [['git', 'checkout', 'main'],
     ... ['git', 'submodule', 'update', '--init', '--recursive']]
     >>> print(execute_commands(cmd))
     RED Previous HEAD position was ... small tweak
-    RED Switched to branch 'master'
+    RED Switched to branch 'main'
 
 Pushing changes
 ---------------

zest/releaser/tests/pyproject-toml.txt

@@ -24,7 +24,7 @@ We remove and add files.
     >>> _ = execute_command(["git", "add", "pyproject.toml"])
     >>> _ = execute_command(["git", "commit", "-m", "Move to pyproject.toml"])
     >>> print(execute_command(["git", "status"]))
-    On branch master
+    On branch main
     nothing to commit, working directory clean
 
 The version is at 0.1.dev0:
@@ -140,5 +140,5 @@ The changelog and pyproject.toml are at 0.2 and indicate dev mode:
 And there are no uncommitted changes:
 
     >>> print(execute_command(["git", "status"]))
-    On branch master
+    On branch main
     nothing to commit, working directory clean

zest/releaser/utils.py

@@ -849,19 +849,32 @@ def get_last_tag(vcs, allow_missing=False):
     # by setuptools' version parsing. A direct match is obviously
     # right. The 'less' approach handles development eggs that have
     # already been switched back to development.
-    available_tags.reverse()
-    found = available_tags[0]
+    # Note: if parsing the current version fails, there is nothing we can do:
+    # there is no sane way of knowing which version is smaller than an unparsable
+    # version, so we just break hard.
     parsed_version = parse_version(version)
+    found = parsed_found = None
     for tag in available_tags:
-        parsed_tag = parse_version(tag)
-        parsed_found = parse_version(found)
+        try:
+            parsed_tag = parse_version(tag)
+        except Exception:
+            # I don't want to import this specific exception,
+            # because it sounds unstable:
+            # pkg_resources.extern.packaging.version.InvalidVersion
+            continue
         if parsed_tag == parsed_version:
             found = tag
             logger.debug("Found exact match: %s", found)
             break
-        if parsed_tag >= parsed_found and parsed_tag < parsed_version:
-            logger.debug("Found possible lower match: %s", tag)
-            found = tag
+        if parsed_tag >= parsed_version:
+            # too new tag, not interesting
+            continue
+        if found is not None and parsed_tag <= parsed_found:
+            # we already have a better match
+            continue
+        logger.debug("Found possible lower match: %s", tag)
+        found = tag
+        parsed_found = parsed_tag
     return found