Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using the general struct 'InboundEvent' to replace the struct 'BTCInboundEvent' used in Bitcoin #2495

Open
ws4charlie opened this issue Jul 17, 2024 · 0 comments
Labels
code-quality Code quality improvement

Comments

@ws4charlie
Copy link
Contributor

Describe the Issue
We've just introduced a general struct InboundEvent for Solana inbound event observation. We should consider unifying the usage of struct InboundEvent and replace the struct BTCInboundEvent used in Bitcoin. The struct is

type InboundEvent struct {
	// SenderChainID is the chain ID of the sender
	SenderChainID int64

	// Sender is the sender address
	Sender string

	// Receiver is the receiver address
	Receiver string

	// TxOrigin is the origin of the transaction
	TxOrigin string

	// Value is the amount of token
	Amount uint64

	// Memo is the memo attached to the inbound
	Memo []byte

	// BlockNumber is the block number of the inbound
	BlockNumber uint64

	// TxHash is the hash of the inbound
	TxHash string

	// Index is the index of the event
	Index uint32

	// CoinType is the coin type of the inbound
	CoinType coin.CoinType

	// Asset is the asset of the inbound
	Asset string
}

Expected Outcome
A description of what outcome you are seeking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-quality Code quality improvement
Projects
None yet
Development

No branches or pull requests

1 participant