-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
standardize repo, gem, and other related naming conventions #144
Comments
I agree on all points! Point of clarification -- In English/written context (presentations, titles) should the capitalization be:
|
I like reactrb the organization name and most projects being reactrb-. I think even reactrb-record has a nice ring to the ear, sounds almost the same as reactive-record, though if reactive-router can be used outside of reactrb, then keeping it reactive-record makes sense. I think for the gem, react.rb is good because it makes it clear that it's react, but w/ruby, ala react w/a ruby file extension. reactrb can be inferred, certainly, but one has to know to separate at the end of react, which probably isn't that much of an issue. I think spelling it out "react dot rb" is just a clearer thing visually and aurally. Looking at reactjs, while main react.js project is under the facebook org, the org is named, reactjs, many projects are react-blah - which makes sense since react.js is the original react, though there is a react.NET under there - https://github.com/reactjs/React.NET which sort of shows a similar precedent. Of couse .NET has always been "dot net". That being said, I'm can be swayed to towards reactrb the gem name, but since the original gem is named that, I also would still stick w/that. |
The dry-rb project also adopts a similar model, although they go with dry-rb. Proposal 1 - ok |
I think the proposals are an excellent improvement |
To answer some of the questions and clarify, and tell you where I think we are at:
If any one out there knows of a reason that we need to keep pushing versions of reactive-ruby please put them forward.
Looking at this I am pretty convinced that overall leaving the reactrb- prefix off the repo name is the way to go, and makes sense. |
regarding case: Okay well I guess I should say it should be capitalized like a normal noun. In otherwords: "Why are you using reactrb?" answer: "Reactrb is really great that is why I am using it." |
On the issue of prefixes and repository names, I think we should generally prefix the repo name with reactrb, i.e. https://github.com/reactrb/reactrb-router - the redundancy is only in url, in your local copy, you never see the redundancy. I might have another |
okay I think we have a plan:
|
Per @catmando's request I'll go ahead and add my thoughts:
Agreeable.
Sounds good.
Smart.
I think we should try to stick to semver guidelines here. In general, when you introduce a breaking change, or a change that isn't backward compatible, the major version number should be incremented. Since this project is in major version zero phase, and perhaps isn't ready to graduate to 1.x.x, I would advocate at least bumping the minor version for this one. So remove react.js and go to version 0.8.x. The key is to develop the features, and let the version number follow. The features that are planned for 0.8.x will just have to go into 0.9.x or 0.10.x or whatever.
Cool. |
Okay so if I understand you @ajjahn, we make reactrb = 0.8.0 which = 0.7.41 + don't load JS, etc. |
Yes to all points. |
@catmando I wouldn't worry about attaching deprecations or other changes to a specific version number. Instead, bump the version number according to what's changed. Also, remember the you can bump the minor and patch numbers as high as you need. So implementing a minor change on 0.9.x doesn't go to 1.0.0, it goes to 0.10.0. |
of course :-) thanks! |
This issue was moved to ruby-hyperloop/hyper-react#144 |
No place to stick an issue for a whole org, so am putting it here for discussion:
There is a new reactrb github org setup. https://github.com/reactrb
PROPOSAL 1:
Because some things will not allow names with a dot like "react.rb" (including github orgs) the proposal is that everything be standardized on reactrb.
Thus the twitter account will stay reactrb, the stackoverflow tag should change to reactrb, the documentation site will stay http://reactrb.org etc.
PROPOSAL 2:
For consistency the gem will be renamed to reactrb.
PROPOSAL 3:
we will deprecate react.rb and reactive-ruby starting with the 0.8 release.
Instead of deprecating reactive-ruby we could continue let reactive-ruby just be a mirror of reactrb which is the current proposal - but is it really needed?
PROPOSAL 4:
Repos inside the organization will be named things like "router", "rails-generator" and "reactive-record", but the gems may be prefixed with reactrb-, like "reactrb-router" and "reactrb-rails-generator" where this is appropriate. The alternative is to make the repos of any gems match the gem name. This is easier but adds redundancy.
PROPOSAL 5:
Use hypens never underscores (i.e. rails-generator)
The text was updated successfully, but these errors were encountered: