Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question about T^TiD and T^DiW #19

Closed
jexterliangsufe opened this issue Nov 30, 2023 · 1 comment
Closed

Question about T^TiD and T^DiW #19

jexterliangsufe opened this issue Nov 30, 2023 · 1 comment

Comments

@jexterliangsufe
Copy link

jexterliangsufe commented Nov 30, 2023 •
edited
Loading

I noticed you take the last slice in the L dimension. In my understanding, T^TiD will change in L dimension. Why don't use t_i_d_data[:, :, -1]? temporal embeddings should have nothing to do with num_nodes
https://github.com/zezhishao/STID/blob/f9801a5d4939e7d3eb100525c1c027cbd34630d3/stid/stid_arch/stid_arch.py#L80-L86
@jexterliangsufe
Copy link
Author

I think I get the answer from #10 . Thanks for your great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jexterliangsufe