RFC: Remove IdentityInterface as type hint on ZF\Rest\Resource

[steverhoades]

Currently, the setIdentity method requires the IdentityInterface (https://github.com/zfcampus/zf-rest/blob/master/src/Resource.php#L82).

This makes a lot of assumptions around what identity means to consuming applications. It makes absolutely no sense in our use case to implement the 15 methods declared in the Zend\MvcAuth\IdentityInterface and is keeping us from using the getIdentity() method on the Resource base class.

I am suggesting that we change:

    /**
     * @param null|IdentityInterface $identity
     * @return self
     */
    public function setIdentity(IdentityInterface $identity = null)
    {
        $this->identity = $identity;
        return $this;
    }

To

    /**
     * @param null|object $identity
     * @return self
     */
    public function setIdentity($identity = null)
    {
        $this->identity = $identity;
        return $this;
    }

This way, I can set our own identity object via the MvcEvent like so

$event->setParam('ZF\MvcAuth\Identity', $authService->getIdentity());

I realize that this was likely done for some other module that performs authentication/authorization if that is the case, I strongly feel those modules should enforce the interface they need instead of the Resource object.

[weierophinney]

This repository has been closed and moved to laminas-api-tools/api-tools-rest; a new issue has been opened at laminas-api-tools/api-tools-rest#4.