Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All deprecated <attr/xattr.h> headers should be switched to <sys/xattr.h> instead. #7344

Closed
fearedbliss opened this issue Mar 25, 2018 · 2 comments
Closed

All deprecated <attr/xattr.h> headers should be switched to <sys/xattr.h> instead. #7344

fearedbliss opened this issue Mar 25, 2018 · 2 comments

Comments

@fearedbliss
Copy link

Hello,

Gentoo has removed/placed in temp QA our "sys-apps/attr-2.4.48" package. With this change, a number of applications that are still relying on the deprecated attr header have since started to fail to compile. ZFS is one of these applications, and means that all of the zfs versions on Gentoo are now failing if they rely on this deprecated library. We will probably patch the sources to use the new headers but I'm not sure if this will lead to any types of regressions.

The folks upstream for attr have recommended for people to switch their headers to the new sys/xattr.h since all attr/xattr.h functionality has been in glibc for a long time.

http://git.savannah.nongnu.org/cgit/attr.git/commit/?id=7921157890d07858d092f4003ca4c6bae9fd2c38

  • Jonathan
@ryao
Copy link
Contributor

ryao commented Mar 27, 2018

I wonder how long ago was ages ago. We could try changing things and see if the buildbot is happy with it. Otherwise, we get to have another autotools check.

@DeHackEd
Copy link
Contributor

tests/zfs-tests/cmd/mktree/mktree.c and tests/zfs-tests/cmd/xattrtest/xattrtest.c seem to be the only files that need xattr.h...

CentOS 6 seems to be okay with a simple:

sed -i s%attr/xattr.h%sys/xattr.h%g tests/zfs-tests/cmd/mktree/mktree.c tests/zfs-tests/cmd/xattrtest/xattrtest.c

And it compiles with /usr/include/attr/xattr.h unusable. CentOS 6 is our oldest supported distro, so I guess that means this is okay.

@DeHackEd DeHackEd mentioned this issue Mar 27, 2018
Merged
13 tasks
tonyhutter pushed a commit to tonyhutter/zfs that referenced this issue Apr 16, 2018
@DeHackEd @tonyhutter
Remove libattr requirement
3765838 
RHEL/CentOS 6 supports sys/xattr.h eliminating the need for
libattr-devel as a dependency.

Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: DHE <git@dehacked.net>
Closes openzfs#7344 
Closes openzfs#7351
tonyhutter pushed a commit to tonyhutter/zfs that referenced this issue May 4, 2018
@DeHackEd @tonyhutter
Remove libattr requirement
c7d556a 
RHEL/CentOS 6 supports sys/xattr.h eliminating the need for
libattr-devel as a dependency.

Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: DHE <git@dehacked.net>
Closes openzfs#7344 
Closes openzfs#7351
tonyhutter pushed a commit that referenced this issue May 10, 2018
@DeHackEd @tonyhutter
Remove libattr requirement
2deb452 
RHEL/CentOS 6 supports sys/xattr.h eliminating the need for
libattr-devel as a dependency.

Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: DHE <git@dehacked.net>
Closes #7344
Closes #7351
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fearedbliss @ryao @DeHackEd