Remove libattr requirement #7351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RHEL/CentOS 6 supports sys/xattr.h eliminating the need for libattr-devel as a dependency. Signed-off-by: DHE <git@dehacked.net>
DeHackEd
changed the title
Codecov Report
@@ Coverage Diff @@
## master #7351 +/- ##
==========================================
+ Coverage 76.15% 76.28% +0.12%
==========================================
Files 329 329
Lines 104191 104191
==========================================
+ Hits 79346 79478 +132
+ Misses 24845 24713 -132
Continue to review full report at Codecov.
|
behlendorf
approved these changes
Mar 27, 2018
dinatale2
approved these changes
Mar 27, 2018
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Apr 16, 2018
RHEL/CentOS 6 supports sys/xattr.h eliminating the need for libattr-devel as a dependency. Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: DHE <git@dehacked.net> Closes openzfs#7344 Closes openzfs#7351
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
May 4, 2018
RHEL/CentOS 6 supports sys/xattr.h eliminating the need for libattr-devel as a dependency. Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: DHE <git@dehacked.net> Closes openzfs#7344 Closes openzfs#7351
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RHEL/CentOS 6 supports sys/xattr.h eliminating the need for libattr-devel as a dependency.
Description
Since
sys/xattr.hfits our needs, we should be able to remove libattr-devel as a package dependency.EDIT: The tests are passing, so I'm changing this from a "test" to a "serious consideration" PR.
Motivation and Context
#7344
How Has This Been Tested?
Build tested with
--with-config=useron a CentOS 6 system with libattr headerschmod 600to effectively eliminate them.Types of changes
Checklist:
Signed-off-by.