Fedora 28: Fix "file is executable, but no shebang" warnings #7395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fedora 28's RPM build checks warn when executable files don't have a shebang line. These warnings are caused when we (incorrectly) include data & config files in the_SCRIPTS automake lines. Files in _SCRIPTS are marked executable by automake. This patch fixes the issue by including non-executable scripts in a _DATA line instead. Signed-off-by: Tony Hutter <hutter2@llnl.gov> Closes: openzfs#7359
tonyhutter
added
the
Type: Building
Codecov Report
@@ Coverage Diff @@
## master #7395 +/- ##
==========================================
- Coverage 76.39% 76.31% -0.08%
==========================================
Files 329 329
Lines 104248 104237 -11
==========================================
- Hits 79638 79552 -86
- Misses 24610 24685 +75
Continue to review full report at Codecov.
|
dinatale2
reviewed
Apr 6, 2018
| @@ -1,4 +1,6 @@ | |||
| pkgdatadir = $(datadir)/@PACKAGE@/test-runner/include | |||
| dist_pkgdata_SCRIPTS = \ | |||
| logapi.shlib \ | |||
| logapi.shlib | |||
There was a problem hiding this comment.
Question: It appears a lot of our other shlib files don't have the shebang at the top of their files. Does logapi.shlib require it for some reason? It's included just like any other shlib files.
There was a problem hiding this comment.
I dunno, I thought that was weird too.
There was a problem hiding this comment.
My understanding is that it's optional since the .shlib files are only ever sourced, but we really should be consistent about it.
behlendorf
approved these changes
Apr 6, 2018
tonyhutter
added a commit
to tonyhutter/zfs
that referenced
this pull request
Apr 16, 2018
Fedora 28's RPM build checks warn when executable files don't have a shebang line. These warnings are caused when we (incorrectly) include data & config files in the_SCRIPTS automake lines. Files in _SCRIPTS are marked executable by automake. This patch fixes the issue by including non-executable scripts in a _DATA line instead. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov> Signed-off-by: Tony Hutter <hutter2@llnl.gov> Closes openzfs#7359 Closes openzfs#7395
tonyhutter
added a commit
to tonyhutter/zfs
that referenced
this pull request
May 4, 2018
Fedora 28's RPM build checks warn when executable files don't have a shebang line. These warnings are caused when we (incorrectly) include data & config files in the_SCRIPTS automake lines. Files in _SCRIPTS are marked executable by automake. This patch fixes the issue by including non-executable scripts in a _DATA line instead. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov> Signed-off-by: Tony Hutter <hutter2@llnl.gov> Closes openzfs#7359 Closes openzfs#7395
tonyhutter
added a commit
that referenced
this pull request
May 10, 2018
Fedora 28's RPM build checks warn when executable files don't have a shebang line. These warnings are caused when we (incorrectly) include data & config files in the_SCRIPTS automake lines. Files in _SCRIPTS are marked executable by automake. This patch fixes the issue by including non-executable scripts in a _DATA line instead. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov> Signed-off-by: Tony Hutter <hutter2@llnl.gov> Closes #7359 Closes #7395
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fedora 28's RPM build checks warn when executable files don't have a shebang line:
These warnings are caused when we (incorrectly) include data & config files in the
_SCRIPTSautomake lines. Files in_SCRIPTSare marked executable by automake. This patch fixes the issue by including non-executable scripts in a_DATAline instead.Motivation and Context
Closes: #7359
How Has This Been Tested?
Tested
make pkg-utilson a Fedora 28 VM and no longer saw the warnings.Types of changes
Checklist:
Signed-off-by.