Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zvol: queue_flag_{set,clear}_unlocked are now private #7410

Merged
merged 1 commit into from Apr 10, 2018

Conversation

dinatale2
Copy link
Contributor

@dinatale2 dinatale2 commented Apr 8, 2018

Description

queue_flag_{set,clear}unlocked are now private interfaces in
the Linux kernel (torvalds/linux@8a0ac14).
Use blk_queue_flag
{set,clear} interfaces which were introduced as
of torvalds/linux@8814ce8.

Motivation and Context

Fix the Kernel Built-in Builder.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the ZFS on Linux code style requirements.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commit messages are properly formatted and contain Signed-off-by.
  • Change has been approved by a ZFS on Linux member.

@dinatale2 dinatale2 added the Status: Work in Progress Not yet ready for general review label Apr 8, 2018
@dinatale2 dinatale2 force-pushed the blk_queue_flags branch 3 times, most recently from 53601bc to c27958b Compare April 8, 2018 05:32
@codecov
Copy link

codecov bot commented Apr 8, 2018

Codecov Report

Merging #7410 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7410      +/-   ##
==========================================
+ Coverage   76.24%   76.29%   +0.04%     
==========================================
  Files         330      330              
  Lines      104235   104239       +4     
==========================================
+ Hits        79472    79526      +54     
+ Misses      24763    24713      -50
Flag Coverage Δ
#kernel 76.15% <100%> (-0.25%) ⬇️
#user 65.61% <ø> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74df0c5...b30553f. Read the comment docs.

queue_flag_{set,clear}_unlocked are now private interfaces in
the Linux kernel (torvalds/linux@8a0ac14).
Use blk_queue_flag_{set,clear} interfaces which were introduced as
of torvalds/linux@8814ce8.

Signed-off-by: Giuseppe Di Natale <dinatale2@llnl.gov>
@dinatale2 dinatale2 removed the Status: Work in Progress Not yet ready for general review label Apr 10, 2018
@behlendorf behlendorf merged commit 10f88c5 into openzfs:master Apr 10, 2018
@dinatale2 dinatale2 deleted the blk_queue_flags branch April 11, 2018 23:30
@tonyhutter tonyhutter added this to TODO in 0.7.9 Apr 12, 2018
@tonyhutter tonyhutter moved this from TODO to In progress in 0.7.9 Apr 12, 2018
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Apr 16, 2018
queue_flag_{set,clear}_unlocked are now private interfaces in
the Linux kernel (torvalds/linux@8a0ac14).
Use blk_queue_flag_{set,clear} interfaces which were introduced as
of torvalds/linux@8814ce8.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Closes openzfs#7410
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request May 4, 2018
queue_flag_{set,clear}_unlocked are now private interfaces in
the Linux kernel (torvalds/linux@8a0ac14).
Use blk_queue_flag_{set,clear} interfaces which were introduced as
of torvalds/linux@8814ce8.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Closes openzfs#7410
tonyhutter pushed a commit that referenced this pull request May 10, 2018
queue_flag_{set,clear}_unlocked are now private interfaces in
the Linux kernel (torvalds/linux@8a0ac14).
Use blk_queue_flag_{set,clear} interfaces which were introduced as
of torvalds/linux@8814ce8.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Closes #7410
teknoman117 pushed a commit to teknoman117/zfs that referenced this pull request Jun 7, 2018
queue_flag_{set,clear}_unlocked are now private interfaces in
the Linux kernel (torvalds/linux@8a0ac14).
Use blk_queue_flag_{set,clear} interfaces which were introduced as
of torvalds/linux@8814ce8.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Closes openzfs#7410
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
0.7.9
  
In progress
Development

Successfully merging this pull request may close these issues.

None yet

2 participants