Split reader part of NativeModel into ModelReader #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonls
force-pushed
the
cache-native-model
branch
6 times, most recently
from
5fe25fa
to
70a7b98
Compare
jonls
force-pushed
the
cache-native-model
branch
from
70a7b98
to
f49ca03
Compare
jonls
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
native, changeNativeModelso that it works as a store of model data in memory. The model parsing is moved to a new classModelReaderwhich can parse individual model sections (e.g. compounds, reactions) and also create a newNativeModelin-memory representation. TheNativeModelis supplied to commands which means that commands no longer have to manually parse the model usingparse_X()methods but can instead access the model entries directly.