Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The model in the Readme may be misspecified #2

Open
mikemc opened this issue Jan 13, 2021 · 1 comment
Open

The model in the Readme may be misspecified #2

mikemc opened this issue Jan 13, 2021 · 1 comment

Comments

@mikemc
Copy link

mikemc commented Jan 13, 2021

The model shown in the Readme right now is $\ln \tilde p_{ij} = \ln p_{ij} + X_{i\cdot} \beta_{\cdot j} + \epsilon_{ij}$, which is missing the sample-specific normalization term $\alpha_i$ from the manuscript and I think would be needed for the proportions to sum to one under the MWC model.
@zhaoni153
Copy link
Owner

Indeed, there is an error. Have corrected now. Thanks for pointing out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikemc @zhaoni153