apple: restrict calling pthread_jit_write_protect_np to macOS >= 11 #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as reported in BUG2769[1], it could result in a miscompiled binary if using a Big Sur SDK but targeting and older version without the call. since macOS in Apple Silicon has a hard requirement for this API in JIT pages, abort with an error for versions older than Big Sur. while at it, add quotes around another #error call for consistency. [1] https://bugs.exim.org/show_bug.cgi?id=2769
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as reported in BUG2769[1], it could result in a miscompiled binary
if using a Big Sur SDK but targeting and older version without the
call.
since macOS in Apple Silicon has a hard requirement for this API in
JIT pages, abort with an error for versions older than Big Sur.
while at it, add quotes around another #error call for consistency.
[1] https://bugs.exim.org/show_bug.cgi?id=2769