Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: script tag #44

Merged
merged 2 commits into from
Mar 27, 2019
Merged

docs: script tag #44

merged 2 commits into from
Mar 27, 2019

Conversation

kingsleydon
Copy link
Contributor

@kingsleydon kingsleydon commented Mar 27, 2019

Description

Should not use self-closing script tags

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@kingsleydon kingsleydon marked this pull request as ready for review March 27, 2019 09:36
@codecov-io
Copy link

codecov-io commented Mar 27, 2019

Codecov Report

Merging #44 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #44   +/-   ##
=======================================
  Coverage   52.98%   52.98%           
=======================================
  Files         123      123           
  Lines        1659     1659           
=======================================
  Hits          879      879           
  Misses        780      780

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7a7b2a...25c1298. Read the comment docs.

@xiaoyuhen xiaoyuhen merged commit 85de203 into zhihu:master Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants