Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typographic error in detrend data #15

Closed
AthenaIak opened this issue Oct 10, 2017 · 1 comment
Closed

Typographic error in detrend data #15

AthenaIak opened this issue Oct 10, 2017 · 1 comment

Comments

@AthenaIak
Copy link

AthenaIak commented Oct 10, 2017 •
edited
Loading

Hello,

CNMF_E/ca_source_extraction/endoscope/detrend_data.m

Line 22 in f1e08e8

if strcmpi(method, 'sline')

I think you want to compare with "spline" (the "p" is missing).

edit: Found another one

CNMF_E/ca_source_extraction/endoscope/greedyROI_endoscope.m

Line 322 in f1e08e8

if sum(ai)<=min_pixel; ind_succwss = false; end

ind_succwss should be ind_success .
@zhoupc
Copy link
Owner

zhoupc commented Oct 11, 2017

ha, thanks for catching these nasty typos. @AthenaIak . they are fixed.

@zhoupc zhoupc closed this as completed Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zhoupc @AthenaIak