Suggestion: use e.g. with warnings.catch_warnings() in favor of module-level warnings suppression

[matthewcarbone]

pyroVED/pyroved/nets/conv.py

Line 20 in 1854047

filterwarnings("ignore", module="torch.nn.functional")

I'd recommend against module-level warnings suppression in favor of

with warnings.catch_warnings():
    warnings.simplefilter('ignore')

at the precise spot where the warnings are thrown.

Thoughts?

[ziatdinovmax]

Yes, this would be a more proper way of doing this. I think here we are suppressing the annoying warning about the align_corners from torch.nn.functional.interpolate.

[matthewcarbone]

Yeah this is definitely more nitpicky an issue for sure... I have had my experiences with a crazy number of warnings from nn.functional too. If at some point I can pin down exactly where the errors come from (and ensure I don't miss any), I will make this change. For now I'd say this is low priority. After all, it's only suppressing warnings, not errors, which by definition shouldn't really impact the code.