Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings from ZSS #56

Open
7ochem opened this issue Dec 6, 2019 · 1 comment
Open

Warnings from ZSS #56

7ochem opened this issue Dec 6, 2019 · 1 comment

Comments

@7ochem
Copy link
Contributor

7ochem commented Dec 6, 2019

Are the limits within these checks outdated? Perhaps these days we need more values (we have more devices and screen sizes than before).

Also, at first, I did not have a clue where these warnings during an NPM build were coming from. I Googled them and, of course, did not find anything. Maybe Zicht ZSS should be included in the description somewhere (for instance WARNING [Zicht ZSS]: ...)

And... The link to the details does not exist anymore because we've removed all the release/z.y.x branches.

WARNING: `$zss--spacing-scale` contains more than 8 values.        This is a design smell that should probably be fixed.        More details: https://github.com/zicht/zss/blob/release/2.1.x/errors/too-many-values.md
         on line 47 of node_modules/zss/src/dev/_strict.scss
         from line 143 of stdin

WARNING: $zss--border-radius-scale` contains more than 5 values.        This is a design smell that should probably be fixed.        More details: https://github.com/zicht/zss/blob/release/2.1.x/errors/too-many-values.md
         on line 138 of node_modules/zss/src/dev/_strict.scss
         from line 143 of stdin
@TowardsDeath
Copy link
Contributor

Are the limits within these checks outdated? Perhaps these days we need more values (we have more devices and screen sizes than before).

The number of values in a scale usually have nothing to do with devices and screen sizes, but with offering a limited set of values a developer can choose from.
If you look at the spacing scale, 8 values should be more than enough to make a good design. For example, 0 4px 8px 16px 24px 32px 48px 64px offers small, large and very large values for margins and paddings.
Also: they're only warnings, which needn't necessarily be fixed. It's an indicator you might be doing something wrong, but if you know what you're doing and know what the effects are, you can ignore them.

At the end of the day, I would advice against using more values. Who needs 6 values for border radius? That's an indication of an inconsistent design.

And... The link to the details does not exist anymore because we've removed all the release/z.y.x branches.

You can easily change the path to master in this file: https://github.com/zicht/zss/blob/master/src/dev/_strict.scss#L38


Just an opinion from a former colleague, do with it what you want 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants