Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate toggles for alarm sounds, basic narration and extra narration #69

Closed
cagils opened this issue May 21, 2020 · 5 comments
Closed
Labels
enhancement New feature or request

Comments

@cagils
Copy link

cagils commented May 21, 2020

It would be great for many people if we could disable narration but keep alarm sounds on as it can be too distracting while doing focused work.

For my use case, I only need to turn off all the narration while keeping the basic alarm sounds. But maybe for a better overall user experience something like the following can also be done:

Sounds

  • [ON/OFF] ALARM SOUNDS
    Only rings at the start of each session/break
  • [ON/OFF] BASIC NARRATION
    AFTER the ring of an alarm, only announce the situation by a three-four-word short speech)
  • [ON/OFF] EXTRA NARRATION
    BEFORE a session/break approaches warn the user and all other extra things currently it is doing)

Notifications (On Screen Popups)

  • [ON/OFF] BASIC NOTIFICATION
    Notify the start of each session/break
  • [ON/OFF] EXTRA NOTIFICATION
    Notify before a session/break approaches

Hope this can be added and also thanks for this little great tool !

@roldanjr
Copy link
Member

That's great but it is very time consuming to refactor my code and add your request.
In my case I don't have much time right now. Maybe I will put it on app's ROAD MAP .

But, if you want as of now I can keep the basic alarm sound and only turn off the narration when you mute the app. Please let me know. Thank you 👍

@cagils
Copy link
Author

cagils commented May 26, 2020

But, if you want as of now I can keep the basic alarm sound and only turn off the narration when you mute the app. Please let me know. Thank you

Yes, only turning off the narration would be enough on my behalf, thanks!

@roldanjr
Copy link
Member

roldanjr commented Jun 1, 2020

@cagils I released new version of the app with some parts of the feature you've requested. Please see Release Notes I've created for more details of changes I've made.

I hope it would help you.

notification-property

@roldanjr roldanjr added the enhancement New feature or request label Jun 3, 2020
@cagils
Copy link
Author

cagils commented Jun 5, 2020

@roldanjrCodeArts9711 That looks amazing! (Sorry I was away for a few days and just seen this. )

This implementation looks clean and fits into the minimalistic design of the app very well. The other features in this release looks also great, thanks.

Have a great day!

@cagils I released new version of the app with some parts of the feature you've requested. Please see Release Notes I've created for more details of changes I've made.

I hope it would help you.

@roldanjr
Copy link
Member

roldanjr commented Jun 8, 2020

Glad to here that @cagils . I think I need to close this. Thank you again.

@roldanjr roldanjr closed this as completed Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants