Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline blame has color same as last character on the line #416

Closed
stribor opened this issue Sep 29, 2022 · 6 comments
Closed

Inline blame has color same as last character on the line #416

stribor opened this issue Sep 29, 2022 · 6 comments
Assignees
Labels

Comments

@stribor
Copy link

stribor commented Sep 29, 2022

Describe the bug
inline blame has the same color as the last character of the line

To Reproduce
open document
click on any line
git blame will be displayed in color of last character on the line

Expected behavior
always have same color of inline comments

Plugin version
Exact plugin version. 212.9.11 EAP Release (2022-09-29T07:50:08.675553)

IDE version
CLion 2022.3 EAP
Build #CL-223.4884.72, built on September 22, 2022

Screenshots
If applicable, add screenshots to help explain your problem.

@zielu
Copy link
Owner

zielu commented Sep 29, 2022

Hi, can you paste screenshot of setting from Preferences > Editor > Color Scheme > GitToolBox Colors with Editor inline blame selected ?

@zielu zielu added the bug label Sep 30, 2022
@zielu zielu self-assigned this Sep 30, 2022
@zielu
Copy link
Owner

zielu commented Oct 1, 2022

Please try 212.9.12. It was possible from inline blame to "inherit" color in case when none was configured in Color Scheme. Now in such case editor text color will be used as fallback.

@zielu zielu closed this as completed Oct 1, 2022
@zielu zielu removed the question label Oct 1, 2022
@stribor
Copy link
Author

stribor commented Oct 2, 2022

Sorry for late reply, I had nothing selected in GitToolBox Colors, all good now, thanks for great plugin!

@LinWanCen
Copy link

Hello, I also encountered this issue while developing plugins. May I ask for your advice on how to solve it?

I have asked this question on the official platform before:
https://youtrack.jetbrains.com/issue/IDEA-300093

My Plugin: Show Comment

Thanks.

@zielu
Copy link
Owner

zielu commented Jan 16, 2024

Hi @LinWanCen, you might find this useful https://plugins.jetbrains.com/docs/intellij/inlay-hints.html.
At the point this issue was solved I was already using inlays but with the most low-level API possible com.intellij.openapi.editor.InlayModel - which is actually quite a chore to implement.

@LinWanCen
Copy link

Thank you very much. Based on your reply, I have found some relevant content and know how to solve it.

#268

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants