-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flecs identifiers #536
Draft
robinheydon
wants to merge
8
commits into
zig-gamedev:main
Choose a base branch
from
robinheydon:flecs_identifiers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Flecs identifiers #536
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
635b643
Added withOptions - fixed memory allocation override - added a number…
robinheydon 55229ff
Merge branch 'zig-gamedev:main' into flecs_identifiers
robinheydon a3592d4
added EcsSystem
robinheydon 47538f3
Merge branch 'flecs_identifiers' of github.com:robinheydon/zig-gamede…
robinheydon 6b44e90
updated ztracy to support latest compiler
robinheydon 23887bb
add include path
robinheydon 870b725
add setMonitor
robinheydon 6c950bf
updated to latest build mechanism
robinheydon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,12 +24,13 @@ pub fn build(b: *std.Build) void { | |
|
||
const options_module = options_step.createModule(); | ||
|
||
_ = b.addModule("root", .{ | ||
const ztracy = b.addModule("root", .{ | ||
.root_source_file = .{ .path = "src/ztracy.zig" }, | ||
.imports = &.{ | ||
.{ .name = "ztracy_options", .module = options_module }, | ||
}, | ||
}); | ||
ztracy.addIncludePath(.{ .path = "libs/tracy/tracy" }); | ||
Comment on lines
+27
to
+33
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Likewise here (changes present on main not showing in diff) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. strange... I'll have a look |
||
|
||
const tracy = b.addStaticLibrary(.{ | ||
.name = "tracy", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what's going on with the diff, but
installArtifact(flecs)
is already being called on main branch, albeit not on this exact line. Can you try rebasing this branch?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, will do.