ci: split out the workflows #61
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenrui333
commented
May 14, 2024
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
jiacai2050
approved these changes
May 15, 2024
jiacai2050
reviewed
May 15, 2024
| @@ -0,0 +1,59 @@ | |||
| name: CI (macOS) | |||
|
|
|||
| on: | |||
There was a problem hiding this comment.
是不是可以复用之前的 ci.yml 文件，然后用两个 job 来区分？这样触发条件就能复用了
There was a problem hiding this comment.
macOS/Linux 理论上应该是一致的，分开的意义不大，很多重复的地方。
现在的不一致只是实现上有些瑕疵，我觉得正确的方式应该是让我们的依赖支持两个平台，这样我们就不用特殊处理了。
Merged
jiacai2050
added a commit
that referenced
this pull request
May 15, 2024
Fix #61, upstream issue: ziglang/zig#15169
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
followup #60