Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why does the reformatter dependency has a version? #83

Closed
akirak opened this issue Jan 21, 2023 · 1 comment
Closed

Why does the reformatter dependency has a version? #83

akirak opened this issue Jan 21, 2023 · 1 comment

Comments

@akirak
Copy link

akirak commented Jan 21, 2023

Hello, since #51, zig-mode uses reformatter.el for running the formatter.

One thing I noticed is that zig-mode depends on at least version 0.6 of the package:

;; Package-Requires: ((emacs "24.3") (reformatter "0.6"))

while the latest version of reformatter is 0 at present:

;; Package-Version: 0

Apparently reformatter.el has no version yet, but 0.6 is bigger than 0, so the latest version of reformatter.el is considered outdated.

Is there any reason @joachimschmidt557 specified 0.6 as the minimum version? Is it just a mistake? If so, I would send a PR to set the minimum version to 0.

@akirak
Copy link
Author

akirak commented Jan 21, 2023

I see it's a tag, which is also a version on MELPA Stable.

@akirak akirak closed this as completed Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant