all: rename i386 to x86 #13101
Merged
all: rename i386 to x86 #13101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vexu
requested changes
Nov 3, 2022
|
The CI failure should be fixed by running |
alichraghi
force-pushed
the
o4
branch
3 times, most recently
from
50b525a
to
03e6590
Compare
|
running |
My bad. |
|
still failing but i think it's easy to fix. will try tomorrow
|
|
hmm new error is so weird. |
The issue was that it was looking for the wrong include directory which can be fixed by renaming it, but doing so makes me question the correctness of the abilist change. |
|
CI is green! let's merge this faster because it get conflicts everyday |
jayschwa
added a commit
to jayschwa/zig
that referenced
this pull request
Nov 6, 2022
PR ziglang#13101 recently renamed the "i386" architecture to "x86", and it seems the specific CPU model got swept up in that. "x86" is an umbrella term that describes a family of CPUs, and the "i386" is the oldest supported model under that umbrella.
kubkon
pushed a commit
that referenced
this pull request
Nov 6, 2022
PR #13101 recently renamed the "i386" architecture to "x86", and it seems the specific CPU model got swept up in that. "x86" is an umbrella term that describes a family of CPUs, and the "i386" is the oldest supported model under that umbrella.
link2xt
added a commit
to deltachat/deltachat-core-rust
that referenced
this pull request
Mar 29, 2023
cargo-zigbuild is replaced with a simple zig-cc wrapper.
cargo-zigbuild still tries to use i386-linux-musl triple,
while in zig 0.11 x86-linux-musl should be used [1].
This also gives us more control over compilation flags used
and prevents changes due to cargo-zigbuild upgrades,
as its version was not pinned.
[1] Merged PR "all: rename i386 to x86 "
<ziglang/zig#13101>
link2xt
added a commit
to deltachat/deltachat-core-rust
that referenced
this pull request
Mar 29, 2023
cargo-zigbuild is replaced with a simple zig-cc wrapper.
cargo-zigbuild still tries to use i386-linux-musl triple,
while in zig 0.11 x86-linux-musl should be used [1].
This also gives us more control over compilation flags used
and prevents changes due to cargo-zigbuild upgrades,
as its version was not pinned.
[1] Merged PR "all: rename i386 to x86 "
<ziglang/zig#13101>
link2xt
added a commit
to deltachat/deltachat-core-rust
that referenced
this pull request
Mar 29, 2023
cargo-zigbuild is replaced with a simple zig-cc wrapper.
cargo-zigbuild still tries to use i386-linux-musl triple,
while in zig 0.11 x86-linux-musl should be used [1].
This also gives us more control over compilation flags used
and prevents changes due to cargo-zigbuild upgrades,
as its version was not pinned.
[1] Merged PR "all: rename i386 to x86 "
<ziglang/zig#13101>
link2xt
added a commit
to deltachat/deltachat-core-rust
that referenced
this pull request
Mar 29, 2023
cargo-zigbuild is replaced with a simple zig-cc wrapper.
cargo-zigbuild still tries to use i386-linux-musl triple,
while in zig 0.11 x86-linux-musl should be used [1].
This also gives us more control over compilation flags used
and prevents changes due to cargo-zigbuild upgrades,
as its version was not pinned.
[1] Merged PR "all: rename i386 to x86 "
<ziglang/zig#13101>
TUSF
pushed a commit
to TUSF/zig
that referenced
this pull request
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4663
not sure what's wrong with Drone CI. that may be a cache issue