stage2: Teach Liveness that some safety checks do not observably modify memory #13233
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spun off from #13074
This is a crude pattern match for try-like
.cond_br
blocks emitted by Sema's safety checks. It looks for:This matches the signature of many of our safety checks which look like this:
The reasoning here is that control flow either diverges (the call must be
noreturn
to be at the end of the block) or continues directly to the following instructions in the block without modifying memory. This was inspired by #11772 (comment)Resolves #12215