crypto.bcrypt: fix massive speed regression when using stage2 #13518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
state: State -> state: *const State Suggested by @nektro Fixes ziglang#13510
|
Please also change the feistelF function state param type to "* const State". I notice that with Zig 0.10.0, changing this parameter type really helps( irrespective of the improvements on the copy elission fixes). |
|
Merging, as performance is critical for this function, but this is a band-aid until the root cause is fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
state: State -> state: *const StateSuggested by @nektro
Fixes #13510