Deduplicate uses of the same package across dependencies #15407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 tasks
|
Alright this is definitely going to need to be changed to account for a more complex dependency tree, but I think this is a step in the right direction, and unblocks some use cases along the way. Thanks. |
|
Agreed, there's for sure more that needs to be done regarding e.g. different versions of the same package, but as you say this is a helpful first step which unblocks some use cases :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very basic implementation. One key thing that this should probably be made to do at some point is validate that every argument passed to the
buildfunction which is used, has the same value on future calls todependency.