syscall: use statx to provide functionality of fstat/fstatat if they are not provided. #18772
Conversation
yxd-ym
changed the title
yxd-ym
changed the title
There was a problem hiding this comment.
Looks to me like we should follow musl's lead and implement fstatat with fstatx on Linux.
The way this works in the Zig codebase is to have std.os.linux faithfully provide syscalls without emulating missing ones. In other words, provide both fstatat and fstatx, and make it a compile error to call one that does not exist.
Meanwhile, it is the task of std.os to provide fstatat and implement it using the fstatx call on linux.
Edit: I forgot to mention, hello, and thank you for sending this patch :-)
Feel free to leave this here and, eventually, someone will complete it for you.
| } | ||
| return @as(usize, @bitCast(-@as(isize, @intFromEnum(E.NOSYS)))); |
There was a problem hiding this comment.
This should be a compile error rather than ENOSYS at runtime. I suggest to retain the pattern that was here before, making the else block call statx.
|
OK, I will wait for a more proper implementation. |
For some platform (e.g. loongarch64),
fstatandfstatatsystem calls are not implemented in Linux kernel. Usestatxsystem call to implementos.fstatandos.fstatif it exists.This will benefit adding loongarch64 support to zig. See patch here: yxd-ym/zig-bootstrap#1
The implementation comes from the idea of golang's implementation https://go-review.googlesource.com/c/go/+/407694