Fix the weird-ass crash on AArch64 #4832
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
It turns out that adding our own implementation of
__addtf3
uncovered a (painfully obvious in hindsight) bug in another unrelated builtin.How
The main clue leading to this discovery was this piece of ASM:
Can you spot the error? No? Because there's no error!
This is the code from
libstdc++
'sPrime_rehash_policy::need_rehash
that's completely correct and indeed works just fine when linked againstlibgcc
or LLVM'scompiler-rt
.What prompted me to look at
__floatundidf
was this piece of code:As you can see it only setups
x0
, the first register used for passing arguments, and, being thexN
registers 64-bit wide, that meantx1
was actually filled with hot garbage! (Remember thatx0-x7
are scratch registers and are not saved across calls).The fix is easy peasy, the big question looming over us is: are there any other mistakes like this?
Proudly closes #4822