Refactor ExtensionsModule to Core-2.0 (except Plugin handling). #2773
Conversation
| $extensionsInFileSystem = $this->get('zikula_extensions_module.bundle_sync_helper')->scanForBundles(); | ||
| $this->get('zikula_extensions_module.bundle_sync_helper')->syncExtensions($extensionsInFileSystem); | ||
| } | ||
|
|
There was a problem hiding this comment.
ping @Guite above, you can see how I would prefer to handle the coupling with MultiSitesModule. There are other instances in this PR also. Here, MultiSites would simply implement and event handler that does whatever checks it needs and then if it wishes to prevent (veto) the regeneration of extensions (modules) then simply stop propagation of the event.
In current code, this is what the MultiSitesModule is checking for this specific instance (the veto would need to actually invert this logic):
if ($this->serviceManager['multisites.enabled'] != 1
|| ($this->serviceManager['multisites.mainsiteurl'] == $request->query->get('sitedns', null)
&& $this->serviceManager['multisites.based_on_domains'] == 0)
|| ($this->serviceManager['multisites.mainsiteurl'] == $_SERVER['HTTP_HOST']
&& $this->serviceManager['multisites.based_on_domains'] == 1)) {
There was a problem hiding this comment.
So Multisites would also use this sync helper for fetching the bundles and process them individually, right?
There was a problem hiding this comment.
no. As I said above, Multisites would use an event handler to veto the regeneration of modules.
craigh
force-pushed
the
extensionmodule-refactor
branch
3 times, most recently
from
c2d7775
to
6fa7ff7
Compare
craigh
force-pushed
the
extensionmodule-refactor
branch
5 times, most recently
from
846efe7
to
826cadd
Compare
craigh
changed the title
craigh
force-pushed
the
extensionmodule-refactor
branch
from
826cadd
to
be90357
Compare
| Q | A | ----------------- | --- | Bug fix? | yes | New feature? | yes | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #2600 | Refs tickets | #1753 | License | MIT | Doc PR | - | Changelog updated | yes - Upgrade ExtensionsModule to Core-2.0 spec except the handling of module and system plugins. - Consolidate all hook-related classes and files into new HookBundle - Correct issue with hook display requiring smarty - fixes #2600 - Add 'info' type of flash message
craigh
force-pushed
the
extensionmodule-refactor
branch
from
f33584d
to
26f0d2e
Compare
Refactor ExtensionsModule to Core-2.0 (except Plugin handling).
Refactor ExtensionsModule to Core-2.0 (except Plugin handling).