Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure how best to proceed with providing final builds to end users through the distribution. In a normal situation, we would not commit the contents of
/public/build
to github. We could maybe do this in the distribution but this could be problematic if the user installs in a subdirectory.currently the publicPath value in
webpack.config.js
is hard-coded to MY value/core.git/public/build
- it would default to simply/build
- because I work in a subdir all the time.Adding this complicates the installation process but provides later flexibility to downline developers.
Additional things I thought of:
setPublicPath('/build')
inwebpack.config.js
setManifestKeyPrefix('build/')
be enabled?)/public/build/
)yarn encore dev
?