-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Symfony/WebpackEncoreBundle #4571
Conversation
I guess one option would be to commit the contents of Doing a search, it looks like there are instances of the path in
opinions? |
@Guite I think I have this ready now. It includes the default assets from webpack and on install, adjust the path if needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Terrific 😄
I'm not sure how best to proceed with providing final builds to end users through the distribution. In a normal situation, we would not commit the contents of
/public/build
to github. We could maybe do this in the distribution but this could be problematic if the user installs in a subdirectory.currently the publicPath value in
webpack.config.js
is hard-coded to MY value/core.git/public/build
- it would default to simply/build
- because I work in a subdir all the time.Adding this complicates the installation process but provides later flexibility to downline developers.
Additional things I thought of:
setPublicPath('/build')
inwebpack.config.js
setManifestKeyPrefix('build/')
be enabled?)/public/build/
)yarn encore dev
?