Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extmenu drag and drop is not available #801

Closed
rallek opened this issue Mar 24, 2013 · 13 comments
Closed

extmenu drag and drop is not available #801

rallek opened this issue Mar 24, 2013 · 13 comments
Labels
Milestone

Comments

@rallek
Copy link
Contributor

rallek commented Mar 24, 2013

in ci build 232 is no drag and drop available to change the sort order of the menu items in extmenu.

@cmfcmf
Copy link
Contributor

cmfcmf commented Mar 24, 2013

Duplicate of #665.

@rallek
Copy link
Contributor Author

rallek commented Mar 24, 2013

a little difference: Now we cant move it, there is nother where to grip the item ;-)

@ghost
Copy link

ghost commented Mar 27, 2013

@craigh - did you fix this - something to do with paths to images.

@craigh
Copy link
Member

craigh commented Mar 27, 2013

my fixes recently were superficial. I think this is an AJAX response issue? I've never used ext menu 😀

@ghost
Copy link

ghost commented Mar 27, 2013

ping @jusuff

@craigh
Copy link
Member

craigh commented Mar 27, 2013

this is a javascript error I think. I'm getting errors in the console like:

TypeError: 'undefined' is not an object (evaluating 'draggable.element.down('a').stopObserving')
TypeError: 'undefined' is not an object (evaluating 'this.dropCache.lastElement = ['after',dropOnNode.identify()]')
TypeError: 'undefined' is not an object (evaluating 'this.dropCache.element = dropOnNode')
TypeError: 'undefined' is not an object (evaluating 'this.dropCache.lastElement = ['before',dropOnNode.identify()]')
TypeError: 'undefined' is not an object (evaluating 'this.dropCache.lastElement')
TypeError: 'undefined' is not an object (evaluating 'draggable.element.down('a').stopObserving')
TypeError: 'undefined' is not an object (evaluating 'this.dropCache.lastElement = ['after',dropOnNode.identify()]')

@cmfcmf
Copy link
Contributor

cmfcmf commented Jul 5, 2013

I tested a bit and figured out that there is something wrong with the recursive option in javascript/helpers/Zikula.itemlist.js. Setting recursive to false (in blocks_block_extmenu_modify.tpl of Blocks module) "solves" the problem. Sorting then works fine.
I actually don't know what the recursive parameter is intended for. Is it for creating nested menus?

- a
- b
--- b1 

@espaan
Copy link
Contributor

espaan commented Jul 25, 2013

It says in itemlist:

 * @param {Boolean} [options.recursive=false] Should list be recursivly sortable (allows to create multilevel lists)

In the extmenu is says that you can also use it as multi level menu. Although I have never seen it being used like that and menutree is far better for that I think.

@phaidon phaidon closed this as completed in e9cff6a Aug 2, 2013
ghost pushed a commit that referenced this issue Aug 2, 2013
Extmenu drag and drop fixed, closes #801.
@espaan
Copy link
Contributor

espaan commented Aug 3, 2013

Nice !

@phaidon
Copy link
Contributor

phaidon commented Aug 3, 2013

Welcome.

@rallek
Copy link
Contributor Author

rallek commented Aug 25, 2013

I changed recursive to false in 1.3.5 and it works. Great!

@cmfcmf
Copy link
Contributor

cmfcmf commented Aug 25, 2013

@rallek Use @phaidon's patch (#924) instead (I adopted it for Zikula 1.3.5, see https://gist.github.com/cmfcmf/6329308). Setting recursive to false was more of a workaround.

@rallek
Copy link
Contributor Author

rallek commented Oct 31, 2013

Thanks to @cmfcmf! I took your adopted patch and it works. Would be great to get it official in #1355. But that is only for security :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants