Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade to Symfony 2.5 #1871

Merged
merged 5 commits into from
Sep 15, 2014
Merged

upgrade to Symfony 2.5 #1871

merged 5 commits into from
Sep 15, 2014

Conversation

Guite
Copy link
Member

@Guite Guite commented Jul 8, 2014

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #1755
Refs tickets -
License MIT
Doc PR -

@Guite Guite added this to the 1.4.0 milestone Jul 8, 2014
@Guite Guite added the Symfony label Jul 8, 2014
@sebastianblum
Copy link

on my machine, my pull request #11350 fixes this issue as well.

@Guite
Copy link
Member Author

Guite commented Jul 8, 2014

@sebastianblum great - looking forward to it :-)

@Guite
Copy link
Member Author

Guite commented Jul 16, 2014

Merged in symfony/symfony@f11da64

@Guite
Copy link
Member Author

Guite commented Jul 16, 2014

Stil getting this extension after running composer:

  [Matthias\SymfonyServiceDefinitionValidator\Exception\InvalidServiceDefinitionsException]                                                                                                                                                         
  Service definition validation errors (1):                                                                                                                                                   
  - form.type_guesser.validator: Argument for type-hint "Symfony\Component\Validator\MetadataFactoryInterface" points to a service of class "Symfony\Component\Validator\ValidatorInterface"

@Guite
Copy link
Member Author

Guite commented Jul 26, 2014

@sebastianblum any idea why validation still fails?

@sebastianblum
Copy link

@Guite I think you are using https://github.com/matthiasnoback/symfony-service-definition-validator or?
I will install it with my symfony installation

@cmfcmf
Copy link
Contributor

cmfcmf commented Jul 27, 2014

Yes, that's what we are using @sebastianblum thanks for your help!

@Guite
Copy link
Member Author

Guite commented Sep 3, 2014

Still no luck with Symfony 2.5.4 unfortunately.

@Guite Guite mentioned this pull request Sep 12, 2014
Closed
@Guite
Copy link
Member Author

Guite commented Sep 12, 2014

Created an issue at the Symfony project for clarification.

@Guite
Copy link
Member Author

Guite commented Sep 12, 2014

Issue moved to the service-definition-validator: matthiasnoback/symfony-service-definition-validator#20

@Guite Guite changed the title [BLOCKED] upgrade to Symfony 2.5 upgrade to Symfony 2.5 Sep 15, 2014
@Guite Guite self-assigned this Sep 15, 2014
Guite added a commit that referenced this pull request Sep 15, 2014
@Guite
Merge pull request #1871 from Guite/1.4
e34e1f8 
upgrade to Symfony 2.5
@Guite Guite merged commit e34e1f8 into zikula:1.4 Sep 15, 2014
craigh
craigh reviewed Sep 15, 2014
View reviewed changes
src/lib/Zikula/Bundle/CoreBundle/Bundle/Bootstrap.php
} else if ($state['state'] == \ModUtil::STATE_UPGRADED && isset($_GET['id']) &&$state['id'] == $_GET['id'] && isset($_GET['secret'])) {
}

if ($state['state'] == \ModUtil::STATE_UPGRADED && isset($_GET['id']) &&$state['id'] == $_GET['id'] && isset($_GET['secret'])) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small formatting issue here &&$state['id']

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Guite Guite

Labels
None yet
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Guite @sebastianblum @cmfcmf @craigh